I believe this misses EXPRESSION_LOGICAL_OR in set_flag_for_operator.

Chris Thompson Answered 2 answers
Question by Chris Thompson 2 years ago

Question

I believe this misses EXPRESSION_LOGICAL_OR in set_flag_for_operator.

Answers

Answered by Daniel McCarthy

Instructor

Hi,
I'm unable to find the function in the commit for this lecture, can you provide the commit please so i can let you know

Follow-up by Chris Thompson

Question author

See https://github.com/nibblebits/PeachCompiler/commit/4bd84284cbc6f14064319a9bf4a43fcedd556ec6#diff-629fe11334ae1d560032cdb6cc6f9a4fbb0f5b1365894b6b648d6ee4d5a654beR861

You'll have to expand the diff for codegen.c, as "Large diffs are not rendered by default".

It could be that you deliberately didn't implement logical or. That's fine if true, it's probably a bit fiddly.